Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm support (closes #39) #42

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Arm support (closes #39) #42

merged 4 commits into from
Feb 4, 2022

Conversation

clarkeash
Copy link
Contributor

I have added in support for arm64 (see #39)
I am having issues with the tests and I am not sure whats going on, @aarondfrancis could you point me in the right direction?
I still need to update the docs

@aarondfrancis
Copy link
Owner

@clarkeash thanks for doing this! I've approved you to run tests, apparently that's a GH thing.

I'll pull this down and see if I can get some passing, and then you can tackle the rest. It really is a mess how much stuff is mocked, but I'm not sure what the better way is.

In the meantime, would you want to add consts for the architectures? Take a look at Runtime for an example. That will help people (me) from fat-fingering an illegal architecture.

Thanks!

@clarkeash
Copy link
Contributor Author

@aarondfrancis I have added the consts for the architectures.

I am still not sure what to do with the failing tests, have you seen InvalidArgumentException: Operation not found: GetFunction before? I am not very familiar with partial mocks.

@aarondfrancis
Copy link
Owner

@clarkeash thank you for doing this! I had to update a few of the tests to match the new arguments. To be honest, I don't love the amount of mocking done in those tests, but I'm not really sure the best way around it at the moment. I think I'll add a bunch of integration tests at some point in the future. Sorry this took so long, and thanks for your patience!

@aarondfrancis aarondfrancis merged commit c107642 into aarondfrancis:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants