WordPress 6.0 backports amendments for PR 2488 #2567
Conversation
…ctory-controller.php.
* Update to stable namespace. * Register routes for WP_REST_Block_Pattern_Categories_Controller * Require class file for WP_REST_Block_Pattern_Categories_Controller * Update expected route for WP_REST_Block_Patterns_Controller * Require class file for WP_REST_Block_Patterns_Controller * Register routes for WP_REST_Block_Patterns_Controller * Girl scouting annotations and formatting
Resolves the `ReflectionException: Class [name of test class] does not have a property named instance`. Error occurred as `getProperty()` is not available on `private` or `protected` properties. This commit uses `ReflectionProperty` to change the `instance` property to `public` for the test. The property is restored to `private` when done.
…y_vars_from_query_block().
ironprogrammer
changed the title
| 'terms' => array( 3, 11, 10 ), | ||
| 'include_children' => false, | ||
| ), | ||
| ), |
There was a problem hiding this comment.
Could this test be duplicated with the new taxQuery set up.
|
Don't we need the updates of packages in order to test this properly? I mean the patterns fetch request is triggered through js here: https://github.com/WordPress/gutenberg/pull/39185/files#diff-278a4a275170c4215a2f4e9d5c0c6d831f9328258220a76cda04b8d9f39f01a5R71. And also in the packages we use Sorry if I'm missing something, but I'm trying to figure this out and test it properly. |
|
@ntsekouras, we decided to split backport commits into as many individual pieces as possible so it's expected that some changes depend on each other. We can test everything once all backports are in place. This is also why we have 3 weeks dedicated to beta testing so we could detect integration issues and fix them. |
| if ( ! is_dir( $dirpath ) || ! is_readable( $dirpath ) ) { | ||
| continue; | ||
| } | ||
| if ( file_exists( $dirpath ) ) { |
There was a problem hiding this comment.
We can skip this check now: WordPress/gutenberg#40259 (comment), since we do it in the above line.
There was a problem hiding this comment.
@ntsekouras, can you move this comment to #2488?
|
Committed with https://core.trac.wordpress.org/changeset/53152. Let's address the remaing issues listed in #2488 seperately. |
Continued amendments to @hellofromtonya's backports for #2488.
This PR builds off the original PR, and addresses reviewer commentary from April 8 and onward. Please use this more recent PR going forward.
Original PR 2488:
Backports changes from Gutenberg to add support for custom taxonomies filtering [Block Library - Query Loop].
lib/compat/wordpress-6.0/blocks.phplib/compat/wordpress-6.0/block-patterns.phplib/compat/wordpress-6.0/block-patterns-update.phplib/compat/wordpress-6.0/class-wp-rest-block-pattern-categories-controller.phplib/compat/wordpress-6.0/class-wp-rest-block-patterns-controller.phplib/compat/wordpress-6.0/class-wp-rest-block-patterns-controller.phpphpunit/class-wp-rest-block-pattern-categories-controller-test.phpphpunit/class-wp-rest-block-patterns-controller-test.phplib/compat/wordpress-6.0/class-wp-theme-json-gutenberg.phpWP_Theme_JSON:: get_patterns()Also being tracked in WordPress/gutenberg#39889.
Trac ticket: https://core.trac.wordpress.org/ticket/55505
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.