-
Notifications
You must be signed in to change notification settings - Fork 64
Add a directive for translators to not translate Netherlands #2191
Conversation
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2191 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
33248be
to
cb81d1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was quick, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding the comment, why not to exclude those words for translations entirely and prevent that from happening?
@krysal do you mean by adding ESLint rules to ignore them and use raw text? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked @krysal's suggestion at first, but then thought that if we ever add those words to the main site text, it would be affected, too. So, I prefer this fix instead.
Sorry for responding late. I wasn't thinking of excluding these words globally, just for the Search Help page. I send a PR with the fix in #2194. |
Fixes
Fixes #2189 by @zackkrida
Description
Add a note for translators to not translate 'network', 'Netflix' and 'Netherlands', which are used as examples of words starting with 'net'. If translated to these would no longer be valid examples.
Alternative
An alternative approach would be to pick a different triplet of words in each language but that would be too cumbersome and wouldn't accurately reflect the English-centric nature of the Openverse search engine.
Testing Instructions
Test that the POT contains the comment.
Checklist
Update index.md
).main
) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin