This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Ping deployer on production Slack notification #2059
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2052 by @krysal
Description
This completes the changes for the production environment, while going back to Python for setting the Slack user as the bash code tried in #2058 didn't work. You can see that the user is not shown correctly:
ef8794f
is the commit with the bash changes. Might only need to usetoJSON
/fromJSON
functions for thegh-slack-username-map
secret, but I'll let that minor improvement for later. The action worked with the python code:Testing Instructions
Just trying an actual deployment.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin