Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Ping deployer on production Slack notification #2059

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

krysal
Copy link
Member

@krysal krysal commented Dec 20, 2022

Fixes

Fixes #2052 by @krysal

Description

This completes the changes for the production environment, while going back to Python for setting the Slack user as the bash code tried in #2058 didn't work. You can see that the user is not shown correctly:

CleanShot 2022-12-20 at 19 42 47@2x

ef8794f is the commit with the bash changes. Might only need to use toJSON/fromJSON functions for the gh-slack-username-map secret, but I'll let that minor improvement for later. The action worked with the python code:

CleanShot 2022-12-20 at 19 51 44@2x

Testing Instructions

Just trying an actual deployment.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Dec 20, 2022
@krysal krysal requested a review from a team as a code owner December 20, 2022 23:54
@github-actions
Copy link

github-actions bot commented Dec 20, 2022

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/2059
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2059/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@krysal krysal force-pushed the improv/prod-deploy branch from fd6a24f to 51919a6 Compare December 20, 2022 23:57
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krysal krysal requested a review from obulat December 21, 2022 15:39
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krysal krysal merged commit ecae72f into main Dec 21, 2022
@krysal krysal deleted the improv/prod-deploy branch December 21, 2022 16:51
github-actions bot pushed a commit that referenced this pull request Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ping person who kicked off deployment in Slack notification
3 participants