This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
the
🟩 priority: low
Low priority and doesn't need to be rushed
label
Nov 20, 2022
@obulat Thank you! |
sarayourfriend
dismissed
their stale review
January 11, 2023 23:42
Requested changes have been addressed.
obulat
approved these changes
Jan 12, 2023
@WordPress/openverse-frontend this could benefit from another review. |
zackkrida
reviewed
Jan 12, 2023
zackkrida
reviewed
Jan 12, 2023
zackkrida
reviewed
Jan 12, 2023
zackkrida
reviewed
Jan 12, 2023
zackkrida
reviewed
Jan 12, 2023
zackkrida
reviewed
Jan 12, 2023
zackkrida
reviewed
Jan 12, 2023
zackkrida
reviewed
Jan 12, 2023
zackkrida
suggested changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so excellent. I've made some small suggestions but am very excited to merge this after those changes are made.
Co-authored-by: Zack Krida <[email protected]>
Co-authored-by: Zack Krida <[email protected]>
Co-authored-by: Zack Krida <[email protected]>
Co-authored-by: Zack Krida <[email protected]>
Co-authored-by: Zack Krida <[email protected]>
Co-authored-by: Zack Krida <[email protected]>
Co-authored-by: Zack Krida <[email protected]>
Co-authored-by: Zack Krida <[email protected]>
zackkrida
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🤖 aspect: dx
Concerns developers' experience with the codebase
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
🟩 priority: low
Low priority and doesn't need to be rushed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1323 by @sarayourfriend
Description
This PR adds the ability to crate a component scaffolding from the command line.
by runing:
pnpm run create:component [component name in PascalCase]
this files will be created:
Testing Instructions
you'll find the details in the main readme file under Frontend Components --> How to create a component, on what commands to run and how to run them in order to create the component scafolding
also please take a look at the template files inside .remake folder, to see if i missed something in the templates
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin