iAPI: Fix the logic path that merges plain objects

[luisherranz]

What?

This is a bug that David and I have been hunting for a while, and David finally found the problem. This regression was introduced in WP 6.7, so this fix should be released in WP 6.7.2.

Fixes a problem accessing getters on the client during the merge of the client and server states on client-side navigation, when the derived state is defined in the server as a Closure.

We should also stop serializing the derived state defined in the server using Closures as a follow-up. I've added the task to the WP 6.8 iteration.

Why?

Because the getters should never be executed without scope.

How?

Refactoring the deepMergeRecursive so it doesn't execute the getters.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: DAreRodz <[email protected]>
Co-authored-by: luisherranz <[email protected]>
Co-authored-by: priethor <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[DAreRodz]

LGTM!

[github-actions]

Flaky tests detected in 0a24a9a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12696005927
📝 Reported issues:

• [Flaky Test] Should insert content using the global inserter #57525 in /test/e2e/specs/widgets/editing-widgets.spec.js

[priethor]

This regression was introduced in WP 6.7, so this fix should be released in WP 6.7.2.

Since this issue was introduced in 6.7, should we add back the Backport to WP minor release label?

I launched earlier the Gutenberg 20.0 release process when this PR wasn't ready, and therefore, I removed the Backport to Gutenberg RC label; however, it is now ready to merge (that was fast 🙂 ). It doesn't to me that this patch warrants the release of a minor GB version, but I'll defer to you if you think so.

[luisherranz]

should we add back the Backport to WP minor release label?

Ah, I thought I had to add that label in the pull request of the backport to the WordPress 6.7 branch. I was planning on doing that next.

It doesn't to me that this patch warrants the release of a minor GB version, but I'll defer to you if you think so.

No, don't worry, it can go in the next version.