Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Card: Remove storybook for internal BlockCard component #68556

Merged

Conversation

Infinite-Null
Copy link
Contributor

@Infinite-Null Infinite-Null commented Jan 9, 2025

Related to: #67165

What?

Removes Storybook documentation for the internal BlockCard component.

Why?

According to recent discussions, internal components that are not intended for public use should not be exposed in Storybook. This keeps our Storybook documentation focused on components that are actually useful for WordPress extenders and makes the documentation more maintainable.

Testing Instructions

  • Run npm run storybook:dev
  • Open Storybook at http://localhost:50240/

Copy link

github-actions bot commented Jan 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Infinite-Null
Copy link
Contributor Author

Hi @t-hamano,

According to this comment internal components should not be exposed in Storybook as they are not intended for use by WordPress extenders. Given that BlockCard is an internal component,This PR removes Storybook documentation to align with this direction.

Please review it at your convenience. Thank You!

@Mamaduka Mamaduka added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components props-bot Adding this label triggers the Props Bot workflow for a PR. labels Jan 9, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 9, 2025
@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 9, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 9, 2025
@Mamaduka Mamaduka merged commit 85d9bad into WordPress:trunk Jan 9, 2025
75 of 76 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants