Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Total: Show Border Controls By Default #68507

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Query Total: Show Border Controls By Default #68507

merged 1 commit into from
Jan 7, 2025

Conversation

shail-mehta
Copy link
Member

Show Border Controls By Default in Query Total Block According to this Comment

Testing Instructions

  • Add Query Total block
  • Verify that Query Total block border Control are showing by default.

Screenshot

image

@shail-mehta shail-mehta added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Query Total Affects the query total block labels Jan 6, 2025
@shail-mehta shail-mehta self-assigned this Jan 6, 2025
@shail-mehta shail-mehta requested a review from t-hamano January 6, 2025 16:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Flaky tests detected in c0e62a2.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12636172779
📝 Reported issues:

@shail-mehta shail-mehta marked this pull request as ready for review January 6, 2025 16:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta mentioned this pull request Jan 6, 2025
Merged
aaronrobertshaw
aaronrobertshaw approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround here @shail-mehta 🚀

LGTM 🚢

Screenshot 2025-01-07 at 11 07 40 am

@aaronrobertshaw aaronrobertshaw merged commit 6847148 into trunk Jan 7, 2025
74 checks passed
@aaronrobertshaw aaronrobertshaw deleted the add/query-total-border-control-by-default branch January 7, 2025 01:09
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 7, 2025
westonruter added a commit that referenced this pull request Jan 7, 2025
@westonruter
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into t…
88d679c 
…ry/interactivity-lazy-hydration

* 'trunk' of https://github.com/WordPress/gutenberg: (143 commits)
  Update: Bundle upload media. (#68522)
  Add: Media field changing ui to Dataviews and content preview field to posts and pages (#67278)
  Bump the react-native group with 2 updates (#68095)
  Check Storybook build on CI for PRs (#68466)
  Bump the github-actions group across 1 directory with 2 updates (#68436)
  Classic theme preview: remove admin-bar class name (#68519)
  Remove geriux as code owner (#68523)
  Post Featured Image: Adds control to clear the the overlay color (#68525)
  Components: Standardize reduced motion handling using media queries (#68421)
  Upgrade Playwright to v1.49 (#68504)
  Document Outline: Use block client ID as unique 'key' (#68502)
  Storybook: Add UnitControl story (#67346)
  Details: Add allowedBlocks and TemplateLock attributes (#68489)
  Post Comment Link: Show Border Control By Default (#68506)
  Query Total: Show Border Controls By Default (#68507)
  RSS: Added Colour support (#66419)
  Refactor: Separate input form styles to a dedicated stylesheet (#68501)
  Code quality: Fix typos (#67304)
  Page List: Added color support (#66430)
  Fix flaky DataViews list arraow nav e2e tests (#68503)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronrobertshaw aaronrobertshaw aaronrobertshaw approved these changes

@t-hamano t-hamano Awaiting requested review from t-hamano

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@shail-mehta shail-mehta

Labels
[Block] Query Total Affects the query total block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.1
Development

Successfully merging this pull request may close these issues.
2 participants
@shail-mehta @aaronrobertshaw