Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Refactor settings panel to use ToolsPanel #68008

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Query: Refactor settings panel to use ToolsPanel #68008

merged 1 commit into from
Jan 12, 2025
+148 −88

Conversation

himanshupathak95
Copy link
Contributor

@himanshupathak95 himanshupathak95 commented Dec 16, 2024 •
edited
Loading

Part of: #67813

What?

Refactored Query Loop Block code to include ToolsPanel instead of PanelBody.

Screenshots

Before After
Settings Expanded
Before - PanelBody interface After - ToolsPanel interface 2 After - ToolsPanel interface 1

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Query Loop Affects the Query Loop Block labels Dec 16, 2024
@fabiankaegy fabiankaegy linked an issue Dec 16, 2024 that may be closed by this pull request
Refactor "Settings" panel of Query Loop block to use ToolsPanel instead of PanelBody #67937
Closed
@himanshupathak95 himanshupathak95 marked this pull request as ready for review December 18, 2024 06:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: himanshupathak95 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

t-hamano
t-hamano approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • ✅ The dropdown is placed on the left side of the sidebar
  • ✅ All controls are visible by default
  • ✅ No visual changes to controls
  • ✅ All reset actions work as expected

@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 12, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 12, 2025
@t-hamano t-hamano merged commit fb3a6a0 into WordPress:trunk Jan 12, 2025
76 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.1
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Query Loop block to use ToolsPanel instead of PanelBody
3 participants
@himanshupathak95 @t-hamano @fabiankaegy