Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Interactivity API benefits of standard documentation link. #64060

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Jul 29, 2024

The previous link https://developer.wordpress.org/block-editor/reference-guides/interactivity-api/what-is-interactivity-api#why-a-standard is invalid and returns a 404 error.
This PR fixes the issue by using a link inside the repository itself.

Testing Instructions for Keyboard

I went to https://github.com/WordPress/gutenberg/blob/5c8575695a9c909931239c86a46a27429889d1fc/docs/reference-guides/interactivity-api/iapi-faq.md#:~:text=all%20the%20benefits%20of%20using%20a%20standard.

Clicked on the using a standard link (search for "All the benefits of using a standard"). and verified it worked as expected.

@juanmaguitar
Copy link
Contributor

LGTM! ✅

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jorgefilipecosta <[email protected]>
Co-authored-by: juanmaguitar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanmaguitar juanmaguitar merged commit e766486 into trunk Jul 29, 2024
69 checks passed
@juanmaguitar juanmaguitar deleted the fix/interactivity-api-why-a-standard-link branch July 29, 2024 16:02
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants