Add margin-bottom lint rules for ToggleGroupControl #63960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Jul 25, 2024
Comment on lines
-196
to
-199
| .components-base-control__help, | ||
| .components-toggle-control { | ||
| margin-bottom: 0; | ||
| } |
| @@ -569,6 +569,7 @@ function BackgroundSizeControls( { | |||
| onChange={ updateBackgroundPosition } | |||
| /> | |||
| <ToggleControl | |||
| __nextHasNoMarginBottom | |||
There was a problem hiding this comment.
Adding these to ToggleControls as well, since we're already here 😘
There was a problem hiding this comment.
Testing instructions
Add a Group block. In the block inspector, go to the Styles tab 
and set a Background image. Click the ItemGroup button with your image now set, and it will show all the controls in a flyout.
|
Size Change: -60 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
49 tasks
mirka
commented
Jul 29, 2024
There was a problem hiding this comment.
Testing instructions
Add an Image block. In the block inspector, choose an Aspect Ratio that is not "Original". The ToggleGroupControl will appear.
mirka
commented
Jul 29, 2024
There was a problem hiding this comment.
Testing instructions
Add a Query Loop block and see the block inspector.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38730
What?
Adds eslint rules to prevent new instances of
ToggleGroupControlto be introduced in the Gutenberg codebase without the__nextHasNoMarginBottomprop being added.Why?
These lint rules should prevent new violating usages from being added, until we are ready to officially deprecate the margins on the BaseControl-based components all at once.
Testing Instructions
See code comments.