Update MediaUpload button for site logo from "Add media" to "Choose logo" #63498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
Size Change: -7 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Jul 13, 2024
I'd still suggest "Add logo". While both are active language, the former is shorter and more clear. Shorter is a benefit for the block toolbar, which especially when set to text labels only can get very wide. |
Site Icon is different than Site Logo. |
I see. So, the possible patterns are either of the following? Personally, I think any of the texts in this list make sense. None of the patterns use the word "icon."
Also, wouldn't sentence case (Add site logo) be more appropriate here rather than title case (Add Site Logo)? |
richtabor
force-pushed
the
tweak/site-logo-upload
branch
from
5b949f8 to
f21f7c4
Compare
|
Went with "Choose logo", and also updated the tooltip to not conflict with the block toolbar.
|
richtabor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes the button much clearer what you are intended to upload. Part of #63327.
I went with "Choose Site Logo" to map to the Site Icon setting in the General Settings admin view.
Other alternatives:
Testing Instructions
Screenshots or screencast