.wp-env.json schema: Fix schema and add unit tests #63281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
|
Flaky tests detected in f8339b5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9851546729
|
t-hamano
force-pushed
the
wp-env-schema-test
branch
from
f8339b5 to
bbf04ac
Compare
t-hamano
changed the title
t-hamano
force-pushed
the
wp-env-schema-test
branch
2 times, most recently
from
b068f99 to
46e393b
Compare
t-hamano
changed the title
t-hamano
changed the title
t-hamano
added
[Type] Developer Documentation
t-hamano
force-pushed
the
wp-env-schema-test
branch
from
77bf60d to
9a52eed
Compare
t-hamano
force-pushed
the
wp-env-schema-test
branch
from
9a52eed to
2da12ee
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
commented
Jul 24, 2024
| import wpEnvSchema from '../../schemas/json/wp-env.json'; | ||
|
|
||
| describe( '.wp-env.json schema', () => { | ||
| const jsonFiles = glob.sync( [ '.wp-env.json' ], { onlyFiles: true } ); |
There was a problem hiding this comment.
I don't think any new .wp-env.json files will be added in the future, but I am concerned that there may be a better pattern.
There was a problem hiding this comment.
I'd remove the jsonFiles array entirely if there's only one.
- Import the
.wp-env.jsonfile just like the schema as an internal dependency. - Remove the
'found .wp-env.json files'test. - Replace the
test.eachwith a singular test. - Replace the
require( filepath )with the imported variable.
ajlende
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #63253
Implement the suggestion in this comment
What?
This PR adds a unit test to validate the wp-env meta schema and the
.wp-env.jsonpresent in the project.At the same time, it fixes errors in the metadata detected by the tests.
Why?
To ensure that we provide a correct meta-schema for developers.
How?
The implementation is similar to the unit tests for other schemas.
Testing Instructions
.wp-env.jsonfile and add the invalid value or property.npm run test:unit test/integration/wp-env-schema.test.jsvalidates schema for ".wp-env.json"test should fail.Please let me know if this problem occurs in your environment.