Editor: Use the 'ConfirmDialog' component in template validation notice #60385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @aduth. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +16.7 kB (+1%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Apr 3, 2024
packages/editor/src/components/template-validation-notice/index.js
Outdated
Show resolved
Hide resolved
| </Notice> | ||
| <> | ||
| <Notice | ||
| className="editor-template-validation-notice" |
There was a problem hiding this comment.
Since this class name is only used in E2E tests, I am wondering if it is possible to delete it.
There was a problem hiding this comment.
Notices are hard to target in e2e tests. Let's keep the class.
Co-authored-by: Aki Hamano <[email protected]>
Co-authored-by: Aki Hamano <[email protected]>
|
Nice! |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…ce (WordPress#60385) Unlinked contributors: aduth. Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: kjellr <[email protected]> Co-authored-by: noisysocks <[email protected]> Co-authored-by: fullofcaffeine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #16583.
Closes #33937.
PR updates
TemplateValidationNoticeto use theConfirmDialogcomponent instead of the nativewindow.configfor displaying the confirmation message.It also includes two additional code quality improvements:
Why?
The new
ConfirmDialogis a recommended component for handling confirmation logic.Testing Instructions
wp.data.dispatch( 'core/block-editor' ).setTemplateValidity( false );Testing Instructions for Keyboard
Same.
Screenshots or screencast