Font Library: Add sanitize from schema util

[matiasbenedetto]

What?

Add ssanitize_from_schema util function.
This function sanitizes the data schema and applies a sanitizer function to the values.

Read the unit tests added in this PR to see several examples of sanitization of different data types.

Why?

We need a function to sanitize nested data, remove unwanted data properties, and apply a sanitizer function to the values.

How?

By implementing the sanitize_from_schema function.

Testing Instructions

• Run unit tests

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ phpunit/tests/fonts/font-library/wpFontUtils/sanitizeFromSchema.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-utils.php

[creativecoder]

Left some initial code comments, this is looking good.

I've been watching the work in #58502 that addresses small issues in the existing font library tests. It seems best if we get those in here from the start so additional cleanup isn't needed later.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: mmaattiiaass, grantmkin.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: matiasbenedetto <[email protected]>
Co-authored-by: creativecoder <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[creativecoder]

This looks good and works as expected in my testing some basic sanitization. The unit tests also do a nice job of showing how usage works.

I think this implementation is very similar to how theme.json is sanitized. At some point we should look into how the functionality could be shared. But until then, having this private access utility function works well.

[matiasbenedetto]

@anton-vlasenko, thank you so much for the review. I merged the PR just a few seconds before seeing it. I'll incorporate the changes you suggested in another PR regarding sanitization.

[anton-vlasenko]

Thank you, @matiasbenedetto!