Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing
useCompositeState
with Ariakit #57304Implementing
useCompositeState
with Ariakit #57304Changes from all commits
17a3f54
47c0a6a
1dcaa9b
0fd8a12
759956b
3e97c18
371c141
37d604d
ac37fc2
3da8c2f
98e4005
a675ad5
778d69d
00f352a
ea9bcb5
25c30e2
3f16fd7
2dc8329
e56959e
14e93f9
5622f48
686ba88
28c5b63
68e4c7d
2f73fb3
096fbf3
132a7cd
f456c74
8a44131
cdd4248
5d54335
aa2e322
030580a
4550f96
07efd5f
d43e02d
68cfe2b
dd6ba63
3bf02ad
acf897c
26d4de8
76e4c7b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storybook flags a minor accessibility issue across the Storybook examples:
"ARIA role gridcell is not allowed for given element"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's complaining about the buttons having a
role
. It's not really that big a deal, particularly in this context.