Site Editor: Add View Link #57153
Merged
Site Editor: Add View Link #57153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
kevin940726
and removed request for
a team
|
Size Change: +343 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 081b21b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7248139222
|
t-hamano
reviewed
Dec 18, 2023
Co-authored-by: Aki Hamano <[email protected]>
Maybe I don't understand exactly, but does it make sense to refer to |
ntsekouras
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Looks good, thank you! I'm approving since the issue @t-hamano mentions already exists in trunk and we can update easily.
If we really want to defer here we could just use:
label={ label }
The view_item label already default is ‘View Post’ / ‘View Page’.
bph
added
the
[Feature] Site Editor
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
Co-authored-by: Aki Hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This PR continues the work on the great unification between post and site editors. This PR moves the ViewLink component from the edit-post package to the editor package and reuse the same panel in the site editor as well. This means that for post types that are viewable in the frontend, there will be a link to "view the page" in the frontend in the header of the editor in the site editor, similar to the post editor.
Testing instructions