[RNMobile] Fix pasting HTML into the post title #57118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic is a duplicate of the web implementation.
The file has been renamed to a proper name now that provides different getters for the editor content.
Now it exports modules using wildcard, instead of needing to specify every single item.
fluiddot
added
[Type] Bug
fluiddot
commented
Dec 15, 2023
| @@ -57,31 +58,45 @@ class PostTitle extends Component { | |||
| this.props.onSelect(); | |||
| } | |||
|
|
|||
| onPaste( { value, onChange, plainText, html } ) { | |||
| onPaste( { value, plainText, html } ) { | |||
There was a problem hiding this comment.
The changes made to this handler are based on the web implementation:
gutenberg/packages/editor/src/components/post-title/index.js
Lines 122 to 162 in ab04a95
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 1a0dc6c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7224995333
|
dcalhoun
approved these changes
Dec 18, 2023
|
I'd like to note that I haven't updated the |
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Update paste handler of post title This logic is a duplicate of the web implementation. * Allow set initial title in integration tests * Add `getEditorTitle` test helper The file has been renamed to a proper name now that provides different getters for the editor content. * Update index of integration test helpers Now it exports modules using wildcard, instead of needing to specify every single item. * Add integration tests of `PostTitle` component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates paste handler logic of the post title to prevent an exception/crash when pasting HTML content.
Why?
This PR is needed to prevent an exception/crash.
How?
If the first element of the HTML pasted in the post title is a paragraph or heading tag, the paste handler will obtain its content:
gutenberg/packages/editor/src/components/post-title/index.native.js
Line 79 in d791ac8
Similar to the issue addressed in #57028, the value provided by the
RichTextcan't be treated as a string. Hence, the above line will produce the exception/crash.This has been solved by utilizing the
toStringfunction to get the content, this is the same approach used in #57028.Additionally, we introduced integration tests to cover this case and others related to pasting content in the post title. In relation to this, some modifications have been applied to the test helpers derived from the test implementation.
Testing Instructions
Howdy).Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A