Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: tab panel: don't render hidden content by default #57046

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Components: tab panel: don't render hidden content by default #57046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4695b66
Components: tab panel: hide hidden content by default
ellatrix Dec 14, 2023
a7be895
Fix e2e
ellatrix Dec 14, 2023
266948b
changelog
ellatrix Dec 14, 2023
d91019c
Fix changelog
ellatrix Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Experimental
youknowriad marked this conversation as resolved.
Show resolved Hide resolved

- `TabPanel`: do not render hidden content ([#57046](https://github.com/WordPress/gutenberg/pull/57046)).

## 25.14.0 (2023-12-13)

### Enhancements
Expand Down
3 changes: 2 additions & 1 deletion packages/components/src/tabs/tabpanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export const TabPanel = forwardRef<
}
const { store, instanceId } = context;
const instancedTabId = `${ instanceId }-${ tabId }`;
const selectedId = store.useState( ( state ) => state.selectedId );

return (
<StyledTabPanel
Expand All @@ -41,7 +42,7 @@ export const TabPanel = forwardRef<
focusable={ focusable }
{ ...otherProps }
>
{ children }
{ selectedId === instancedTabId && children }
</StyledTabPanel>
);
} );
2 changes: 1 addition & 1 deletion packages/e2e-tests/specs/editor/various/editor-modes.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ describe( 'Editing modes (visual/HTML)', () => {
'//button[@role="tab"][contains(text(), "Block")]'
);
inactiveBlockInspectorTab.click();
const noBlocksElement = await page.$(
const noBlocksElement = page.waitForSelector(
'.block-editor-block-inspector__no-blocks'
);
expect( noBlocksElement ).not.toBeNull();
Expand Down
Loading