Cherry-picked commits for WordPress 6.4.2 #56010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses. (#55890) * Use tagName if exists * Added a test using string positions, we could refactor * Refactor to use Tag Processor
* Add a function to return a text-only label. * Use already defined isAppleOS function from keycodes. Remove new OS functions from element. * Add fallback if textLabel is unavailable. * Try combobox role to get around annoying re-rendering type effect. * Changelog entry. * Revert Windows fix, too much scope creep. * Fix Changelog. * Remove diff artifact. * Remove mistaken files. * Add comment linking to PR. * Revert textLabel prop. # Conflicts: # packages/components/CHANGELOG.md
…55607) * Check for existing categories when renaming to avoid creating a duplicate * Add a spoken message when a renaming errors occur * Convert to lowercase before comparison * Clear validation messages when entering new text * Improve styling of validation message # Conflicts: # packages/edit-site/src/components/page-patterns/rename-category-menu-item.js # packages/patterns/src/components/rename-pattern-category-modal.js
mikachan
added
the
[Type] WP Core Ticket
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/blocks/render-query-test.php |
|
Size Change: +539 B (0%) Total Size: 1.63 MB
ℹ️ View Unchanged
|
|
Is it too late to add another one 🥺 ? Thank you! |
…n-ASCII encoding (#55912) * downloadjs has a bug where it cannot decode non-ASCII characters. Gutenberg's reusable blocks code has an existing download function that we can use for JSON. This commit removes the downloadjs dependency and copies over the reusable blocks download function. * Added comment to explain duplicate * Remove IE11-specific code.
* Add context for translators to any unclear usage of synced * Remove toggle in translator comment * Use _x
No worries, got it! |
|
Flaky tests detected in f42a5ef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6853456007
|
|
I'm going to merge this as I'd like to make sure we get the above fixes in the next 6.4 point release. If there are further fixes, please continue using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest commits for WP 6.4.2.
Included changes: