[Social icons] - Fix that icons without a link are invisible #55878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the Don't render if no URL st now render icons whitout URL Co authors @tiniacoleyba @DanoValero
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @cehojac! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
cehojac
commented
Nov 5, 2023
cbravobernal
added
the
[Type] Bug
Mamaduka
added
the
[Block] Social
|
Thanks for your contribution! In order to fix the linting issues, please run |
cbravobernal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the Don't render if no URL st
now render icons whitout URL
Co authors
@tiniacoleyba
@DaniValero
What?
Fixes #55543.
Why?
The problem is about show the social icons whitout link previously edited.
How?
Removing the lines about don't render if url is false or empty
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast