Top toolbar: Fix issues with save button overlap, and plugin buttons #53101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: +101 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jul 28, 2023
|
Thank you! Is this properly tagged to be backported or do we need to ping someone? |
|
@jasmussen I still see the save draft covered a bit in FF 
|
draganescu
added
Backport to WP 6.7 Beta/RC
|
I can't reproduce the issue you mention in Firefox, but let me know if I'm missing a piece and I'm happy to follow up. 
|
|
I just cherry-picked this PR to the update/second-round-6-3-rc3 branch to get it included in the next release: 0ea6c91 |
tellthemachines
pushed a commit
that referenced
this pull request
Aug 1, 2023
…53101) * Shorten the width of the top toolbar overlay and make doc title smaller. * Add a scrim and a margin to handle plugin buttons better.
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
|
Thanks for fixing this! I just noticed in testing that top toolbar with text labels isn't looking too good: |
tellthemachines
added a commit
that referenced
this pull request
Aug 1, 2023
* Top toolbar: Fix issues with save button overlap, and plugin buttons (#53101) * Shorten the width of the top toolbar overlay and make doc title smaller. * Add a scrim and a margin to handle plugin buttons better. * Remove block tools back compat component schedule for deprecated in 6.3 (#53115) * Removes usage of BlockToolsBackCompat * Remove unwanted BlockTools from Nav sidebar * Footnotes/RichText: fix getRichTextValues for deeply nested blocks (#53034) * Defer to preceding handlers in command palette keyboard shortcut (#53001) * Image block: fix image size at wide and full width (#53184) * Fix regression with Edit site Navigate regions (#52940) * Make the navigabel region wrap the inert sidebar. * Adjust animation. * Fix not expanding pattern in page editor (#53169) --------- Co-authored-by: Aaron Robertshaw <[email protected]> * Footnotes: fix published preview (#53072) * Footnotes: fix published preview * remove var dump * Fix php lint * PHP lint * Address feedback * Add e2e test * Footnotes: disable for synced patterns and prevent duplication for pages in site editor (#53003) * Initial commit: - Prevent footnote creation withing core/block - Only insert a footnote if one isn't found in the entity block list * Try grabbing controlled blocks from parent post content block * Cache `selectedClientId` Get hasParentCoreBlocks using separate useSelect call. * Rename hasParentCoreBlocks to isBlockWithinPattern Add comments * Removing while loop since we're already fetching the post content parent in the `getBlockParentsByBlockName` call above * Reinstating while loop because it can deal with nested blocks --------- Co-authored-by: Andrew Serong <[email protected]> * Footnotes: add missing _ in revision field filter (#53135) * Footnotes: add missing _ in revision field filter * Use correct hook name * Revert prefixing callback names * don't display BlockContextualToolbar at all in contentonly locking (#53110) * Render the footer conditionally in the global styles sidebar component so that any side effects from the footer wrapper are not rendered, e.g., styles and what not (#53204) Ensure that the precise bottom margin persists if the footer isn't rendered * Pattern: Add getBlockRootClientId call (#53206) --------- Co-authored-by: Joen A <[email protected]> Co-authored-by: Dave Smith <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Mitchell Austin <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Andrea Fercia <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Ramon <[email protected]> Co-authored-by: Andrew Serong <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]>
mikachan
added
[Package] Block editor
|
I think the button labels view mode needs a lot of care and love lately 😆 |
|
It needs as much care and love as the icon view! The problem is it's often forgotten about 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a bugfix to handle cases of the top toolbar covering the save button, and not correctly covering plugin buttons.
Why?
There are a couple of bugs with the top toolbar mode. It partially covers the "Save draft" and "Saved" state indicators in the post editor:
When a plugin adds buttons to the top toolbar area, it is incorrectly covered:
This PR fixes both issues.
How?
It is worth noting, that there is no official API for adding buttons to the top toolbar like some plugins do. It is for exactly this reason, the full behavior of the top toolbar and how it behaves responsively and in cases like these, is still being refined.
Testing Instructions
Screenshots or screencast
After, block selected:
After, block selected and toolbar collapsed:
After, toolbar collapsed in site editor:
After, toolbar expanded in site editor: