-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump plugin minimum supported PHP version to 7.0 #52982
Conversation
Flaky tests detected in 657a8e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5671454844
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @hellofromtonya!
Looks like that's all the references to 5.6 updated, other than the headers in test themes but I don't think there's any reason or benefit to bump those each time 😆
I debated whether to bump them or not. Like you said @costdev, I didn't see a benefit to bumping them. |
Alrighty, seems to be enough consensus on the issue and approvals on this PR. Let's do the bump. |
Thank you everyone! The version has been bumped 🎉 |
Closes #52344
What?
testVersion
from5.6-
to7.0-
.Test with previous WP version
fromphp: 5.6
tophp: 7.0
.Why?
WordPress Core parity.
WordPress 6.3.0's minimum supported PHP version is/will be 7.0.
How?
Modifies the plugin header's
Requires PHP:
from5.6
to7.0
.Testing Instructions
gutenberg.php
file, and in the file's DocBlock changeRequires PHP:
back to7.0
.Expected: Stays activated, bulk actions disabled, and a notice appears:
Expected: Bulk edit is disabled;
Cannot Activate
is displayed but not clickable; notice appears:Screenshots