Don't use global 'select' in the Behaviors controls component #51028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
artemiomorales and
michalczaplinski
and removed request for
ellatrix
Mamaduka
added
[Type] Code Quality
Mamaduka
commented
May 27, 2023
| @@ -30,73 +90,28 @@ import merge from 'deepmerge'; | |||
| */ | |||
| export const withBehaviors = createHigherOrderComponent( ( BlockEdit ) => { | |||
| return ( props ) => { | |||
| const blockEdit = <BlockEdit key="edit" { ...props } />; | |||
There was a problem hiding this comment.
This addressed @youknowriad's feedback from the original PR - ##49972 (comment).
|
Size Change: +49 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
cbravobernal
force-pushed
the
update/behavior-ui-controls
branch
from
c780e1c to
ecdde43
Compare
cbravobernal
added
the
Backport to Gutenberg RC
|
Flaky tests detected in ecdde43. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5110283227
|
cbravobernal
approved these changes
May 29, 2023
|
Cherry picked for Gutenberg 15.9 RC2 |
cbravobernal
pushed a commit
that referenced
this pull request
May 29, 2023
cbravobernal
removed
the
Backport to Gutenberg RC
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #49972.
PR refactors the Behaviors controls integration to avoid using the global
selectcalls.Why?
Using global
selectis considered a bad pattern as it only works with the default registry, not custom registry providers.How?
PR extracts control into a separate component so that we can use the
useSelecthook.Testing Instructions
Screenshots or screencast