Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behaviors UI #49972
Behaviors UI #49972
Changes from 55 commits
bd53de2
bd43bf6
e1dd737
8b84a22
d5dbc1c
037d669
8f62d34
62b6217
edfd7d1
8ee4065
594224b
fd6fe36
da4a5ad
2958fd1
0a68bea
fd08928
4e03e0d
92b6e6c
ffa881e
99c964b
7f7db2c
5e5ff9a
ad20b64
d16266b
0982d9f
0ef7b5e
e75fd87
f6414f9
31c0623
ee3701f
a0ac748
1dd6df1
a737200
3fd9270
5a9748c
9a6b1f2
1c7f6d5
470f74f
bba7c2d
2cb348c
c65bc57
1c655f7
697c04f
d4fd9d9
a57d634
234a8b6
4bef633
7aa7231
1d923ab
aee908a
33cb62d
55e37a3
d4d657b
8d6b0d0
76b2a75
70e51cd
69ebe6c
c32be86
b8dc7dd
4800d91
9124b58
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a subtile issue that may or may not result in a bug. The fact that we conditionally render
BlockEdit
can result in a "remount" of the whole component if the condition above changes from "true" to "false" or the opposite.The remount often create focus loss and issues like that. While this might not always be a problem, it is a problem in general if the condition "can" change when the component is mounted (I'm not sure it's the case here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That conditional is reading a theme.json value. I don't think that condition can change without a page reload 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, probably fine for now, just something to know as sometimes we used to switch over attribute values (easy to add a check there). Also, maybe at some point in the future, that setting could be editable in the global styles UI in the site editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the next step after merging this PR, so we should then take a look at this issue.