Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes image size description, as it causes confusion #48478

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Changes image size description, as it causes confusion #48478

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1be5ded
Changes image size description, as it causes confusion
tomdevisser Feb 27, 2023
59aa614
Added the copy to the Image block as well
tomdevisser Feb 27, 2023
112a96f
Fix typo and make copy shorter
tomdevisser Feb 28, 2023
5e423c1
Merge branch 'trunk' into pr/48478
richtabor Mar 28, 2023
90d7960
Update help labels for consistency
richtabor Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/block-library/src/image/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,9 @@ export default function Image( {
isResizable={ isResizable }
imageWidth={ naturalWidth }
imageHeight={ naturalHeight }
imageSizeHelp={ __(
"Select which image size to load. This changes the resolution of the image, not it's visual size."
tomdevisser marked this conversation as resolved.
Show resolved Hide resolved
) }
/>
</PanelBody>
</InspectorControls>
Expand Down
4 changes: 3 additions & 1 deletion packages/block-library/src/media-text/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,9 @@ function MediaTextEdit( { attributes, isSelected, setAttributes, clientId } ) {
slug={ mediaSizeSlug }
imageSizeOptions={ imageSizeOptions }
isResizable={ false }
imageSizeHelp={ __( 'Select which image size to load.' ) }
imageSizeHelp={ __(
"Select which image size to load. This changes the resolution of the image, not it's visual size."
) }
/>
) }
{ mediaUrl && (
Expand Down