Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove copy for managing a block's style variations #48367

Merged
merged 7 commits into from
Feb 25, 2023
Merged

Remove copy for managing a block's style variations #48367

merged 7 commits into from
Feb 25, 2023

Conversation

tomdevisser
Copy link
Member

@tomdevisser tomdevisser commented Feb 23, 2023 •
edited by Mamaduka
Loading

What?

Resolves #48050.

I improved the copy and made it translatable.

Why?

The copy in question was: "Manage style variations, saved block appearence presets."

There's a typo (appearence should be appearance), and grammar — but I think we can do better all around. It's not clear where "block appearance presets" came from, but it seems like a fancier way to say "style variations".

Together we came to the best copy for this issue, considering accessibility.

Testing Instructions

  1. Go to your site editor
  2. Open global styles
  3. Click Blocks
  4. Click Button
  5. Check the copy

Screenshots or screencast

Screenshot 2023-02-23 at 4 43 12 PM

@tomdevisser
Improve copy for managing a block's style variations
2df4231 
The copy in question was: "Manage style variations, saved block appearence presets."

There's a typo (appearence should be appearance), and grammar — but I think we can do better all around. It's not clear where "block appearance presets" came from, but it seems like a fancier way to say "style variations".

Together we came to the best copy for this issue, considering accessibility.

I also made the copy translatable.

Props richtabor, ndiego, ntsekouras.
Fixes WordPress#48050.
@tomdevisser tomdevisser requested review from tellthemachines, noisysocks and carolinan and removed request for tellthemachines and noisysocks February 23, 2023 15:43
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 23, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @tomdevisser! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@tomdevisser tomdevisser mentioned this pull request Feb 23, 2023
Closed
@Mamaduka Mamaduka added [Type] Copy Issues or PRs that need copy editing assistance Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Feb 23, 2023
@ntsekouras ntsekouras added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 23, 2023
ntsekouras
ntsekouras approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tomdevisser ! Code wise this is good to go.

Let's get a confirmation for the updated copy and land. --cc @ndiego @richtabor @jameskoster

@jameskoster
Copy link
Contributor

Possibly a radical idea, but do we need this copy at all? It seems a bit repetitive and unhelpful.

@tomdevisser
Copy link
Member Author

Possibly a radical idea, but do we need this copy at all? It seems a bit repetitive and unhelpful.

That was my first comment on the issue #48050 (comment) , but wasn't agreed upon. So this seems like a good compromise, at least for now. 🙂

@jameskoster
Copy link
Contributor

I'll defer to @richtabor since he's probably thought about this in more detail.

@richtabor
Copy link
Member

Possibly a radical idea, but do we need this copy at all? It seems a bit repetitive and unhelpful.

Yea, it's not particularly helpful. I'm fine with adapting this PR remove the help text.

richtabor
richtabor previously requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change of plans; let's just remove this text.

@tomdevisser tomdevisser self-assigned this Feb 24, 2023
apeatling
apeatling approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this is needless copy, better to remove. 👍

@Mamaduka Mamaduka dismissed richtabor’s stale review February 25, 2023 05:42

The copy was removed.

@Mamaduka Mamaduka merged commit d75741c into WordPress:trunk Feb 25, 2023
@github-actions github-actions bot added this to the Gutenberg 15.3 milestone Feb 25, 2023
@tomdevisser tomdevisser deleted the update/copy-manage-style-variations branch February 25, 2023 15:38
@ntsekouras ntsekouras changed the title Improve copy for managing a block's style variations Remove copy for managing a block's style variations Feb 27, 2023
@ntsekouras
Copy link
Contributor

I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: c735ffb

ntsekouras added a commit that referenced this pull request Feb 27, 2023
@tomdevisser @ntsekouras
Remove copy for managing a block's style variations (#48367)
c735ffb 
Co-authored-by: Nik Tsekouras <[email protected]>
@ntsekouras ntsekouras removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 27, 2023
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jun 14, 2023
@femkreations femkreations mentioned this pull request Jul 10, 2023
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@apeatling apeatling apeatling approved these changes

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@carolinan carolinan Awaiting requested review from carolinan

@noisysocks noisysocks Awaiting requested review from noisysocks

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@richtabor richtabor Awaiting requested review from richtabor

Assignees

@tomdevisser tomdevisser

Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs User Documentation Needs new user documentation [Type] Copy Issues or PRs that need copy editing assistance
Projects
No open projects
WordPress 6.2 Editor Tasks
Status: ✅ Done
Milestone
Gutenberg 15.3
Development

Successfully merging this pull request may close these issues.

Improve copy for managing a block's style variations
7 participants
@tomdevisser @jameskoster @richtabor @ntsekouras @Mamaduka @apeatling @femkreations