rich-text: Fix bug where bare tag name format types could not be registered #46798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes #46795. It also tweaks the test suite to account for the reported bug.
Why?
Users should be able to register format types to handle bare tag names. Unfortunately, this is currently not possible as described in #46795.
How?
When registering a new format type name/format, the code now checks if the existing format type that handles a bare tag name xxx is
core/unknown
. If it is, it means nobody registered a specific format type for tag name xxx and, therefore, name/format should be allowed.Testing Instructions
It should work.
It should fail because tag name
xxx
is already handled byname/format
(registered in step 3).