BorderControl: improve popover waiting #46713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
|
Size Change: +14 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
@jsnajdr, the failing unit tests look like related to the changes in this PR. Other than that, the refactoring looks good to me and is similar to the changes applied for other unit tests. |
Yes, they are definitely related, I'm working on them. |
They are green again after enabling real timers explicitly. With fake timers, there's an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the
BorderControlunit tests by:renderBorderControlandrerenderBorderControlhelpers and replace them with directrenderandrerendercalls. Also they don't need to be async, as they don't need to do anyawait act()call. Only opening a popover requires something like that.