-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns API: Add 'inserter' to the schema #40416
Conversation
Thanks for this @Mamaduka! This PR fixes the root issue, both for patterns registered via JS and PHP in the |
@Mamaduka, once merged, let's add the backport tag. This should get in 6.0. |
Thanks, @ndiego. I think those are flaky tests. |
8db2271
to
c3a085c
Compare
@adamziel, @gziolo, here's WP core PR - WordPress/wordpress-develop#2600. |
Actually, there is nothing to do about this PR in the context of WordPress core. Let's add the linked PR in core to the project. |
Backports changes from WordPress/gutenberg#40416. Adds the missing `inserter` field to the Patterns item schema. This field was omitted from the response, and patterns that should be hidden in the inserter were visible. Props mamaduka, ndiego. See #55567. Follow-up [53152]. git-svn-id: https://develop.svn.wordpress.org/trunk@53210 602fd350-edb4-49c9-b593-d223f7449a82
Backports changes from WordPress/gutenberg#40416. Adds the missing `inserter` field to the Patterns item schema. This field was omitted from the response, and patterns that should be hidden in the inserter were visible. Props mamaduka, ndiego. See #55567. Follow-up [53152]. Built from https://develop.svn.wordpress.org/trunk@53210 git-svn-id: http://core.svn.wordpress.org/trunk@52799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Backports changes from WordPress/gutenberg#40416. Adds the missing `inserter` field to the Patterns item schema. This field was omitted from the response, and patterns that should be hidden in the inserter were visible. Props mamaduka, ndiego. See #55567. Follow-up [53152]. Built from https://develop.svn.wordpress.org/trunk@53210 git-svn-id: https://core.svn.wordpress.org/trunk@52799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
What?
Fixes #40414.
PR adds the missing
inserter
field to the Patterns item schema.Why?
Currently, this field is omitted from the response, and patterns that should be hidden in the inserter are visible.
Testing Instructions