-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Styles: Update "Other styles" to "Browse styles" #39752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
A suggestion for improvement.
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
labels
Mar 25, 2022
Size Change: -3 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
mtias
approved these changes
Mar 25, 2022
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In Global Styles when you have copies of theme.json in a "styles" theme subfolder, you can switch to one of those variants in the interface. This PR changes the title from "Other styles" to "Browse styles".
Before:
After:
Why?
It's a better label for a cool feature.
Testing Instructions
Easiest to test with the "Empty Theme" variant that comes with the docker install of this repo, it has a few style variants. Activate the theme, go to global styles, and observe the label change.