Rename name to title in the global style variations #39715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
requested review from
scruffian,
mtias,
oandregal,
kjellr and
jasmussen
youknowriad
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
jasmussen
approved these changes
Mar 24, 2022
|
Size Change: -2 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
|
According to https://github.com/WordPress/gutenberg/pull/39322/files we also need to update |
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #39322
What?
This PR renames the "name" property of the global styles variations/presets to "title".
Why?
I noticed that "name" was used more as an identifier in a lot of places in our code base: Block Types, Block Categories, Block Pattern Categories while "title" was used to refer to "labels" (sometimes "label" is used) for patterns, block types.