WIP: fix using StyleProvider with Iframe
#38447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
commented
Feb 2, 2022
Comment on lines
+97
to
+117
| // export const _iframe = () => { | ||
| // const iFrameRef = useRef( null ); | ||
|
|
||
| // const redText = css` | ||
| // color: red; | ||
| // `; | ||
| // const blueText = css` | ||
| // color: blue; | ||
| // `; | ||
|
|
||
| // return ( | ||
| // <Iframe ref={ iFrameRef }> | ||
| // <Example args={ [ redText ] }>This text should be red</Example> | ||
| // <StyleProvider document={ iFrameRef.current?.contentDocument }> | ||
| // <Example args={ [ blueText ] }> | ||
| // This text should be blue | ||
| // </Example> | ||
| // </StyleProvider> | ||
| // </Iframe> | ||
| // ); | ||
| // }; |
There was a problem hiding this comment.
Solution attempt no. 1 (manually getting the Iframe's contentDocument and passing it to StyleProvider)
ciampo
commented
Feb 2, 2022
Comment on lines
+118
to
+142
| // export const _iframe = () => { | ||
| // const redText = css` | ||
| // color: red; | ||
| // `; | ||
| // const blueText = css` | ||
| // color: blue; | ||
| // `; | ||
|
|
||
| // const Content = ( { iframeDocument } ) => ( | ||
| // <> | ||
| // <Example args={ [ redText ] }>This text should be red</Example> | ||
| // <StyleProvider document={ iframeDocument }> | ||
| // <Example args={ [ blueText ] }> | ||
| // This text should be blue | ||
| // </Example> | ||
| // </StyleProvider> | ||
| // </> | ||
| // ); | ||
|
|
||
| // return ( | ||
| // <Iframe> | ||
| // <Content /> | ||
| // </Iframe> | ||
| // ); | ||
| // }; |
There was a problem hiding this comment.
Solution no. 2: modify the Iframe component to pass the iframeDocument prop to its children (see changes in packages/block-editor/src/components/iframe/index.js)
ciampo
commented
Feb 2, 2022
Comment on lines
143
to
161
| export const _iframe = () => { | ||
| const redText = css` | ||
| color: red; | ||
| `; | ||
| const blueText = css` | ||
| color: blue; | ||
| `; | ||
|
|
||
| return ( | ||
| <Iframe> | ||
| <Example args={ [ redText ] }>This text should be red</Example> | ||
| <StyleProvider document={ document } whichOne="internal"> | ||
| <Example args={ [ blueText ] }> | ||
| This text should be blue | ||
| </Example> | ||
| </StyleProvider> | ||
| </Iframe> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Solution no. 3 (currently WIP and not working): instead of adding the fix to the "consumer" code, try to fix the issue directly in StyleProvider by using React's Context to store the correct document / head and re-use it in children components.
|
Size Change: +60 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
fix/emotion-style-provider-iframe
branch
from
862aa01 to
9bdd098
Compare
|
Closing this PR after having decided, together with @sarayourfriend , that the pattern that we were trying to fix (i.e. We also gained more insights on what could be the problem behind #35619 (comment) — I'm going to open a PR in the upcoming days with more details about that. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
For context, see #37551 (comment) and #35619 (comment)
Testing Instructions
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).