Custom color palette: add default color name #36940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +43 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
mtias
reviewed
Nov 29, 2021
mtias
approved these changes
Nov 29, 2021
|
Thanks, @ramonjd, this works well. I've noticed that the text strings include whitespace at the end (e.g.: "Color 5 "). Is that on purpose? If there's not a reason for that, could you remove it? |
mtias
reviewed
Nov 29, 2021
No reason other than this PR is still WIP and was slapped together without much testing 😆 Thanks for testing @javierarce and for the commit @mtias 🙇 |
ramonjd
force-pushed
the
try/add-default-name-custom-color
branch
from
fd29637 to
d41a18e
Compare
ramonjd
added
[Type] Enhancement
ramonjd
changed the title
|
Looking at the Gutenberg commit history, the failing test for |
ramonjd
force-pushed
the
try/add-default-name-custom-color
branch
from
d41a18e to
bb7d2ba
Compare
ramonjd
force-pushed
the
try/add-default-name-custom-color
branch
from
bb7d2ba to
8a180e6
Compare
noisysocks
added
the
Backport to WP 6.7 Beta/RC
|
I'd like to get this into 5.9 beta 2. It's marked as an enhancement but it fixes a common source of frustration and isn't a very large code change. |
👍 We can do the smaller UI change in a separate PR:
From #36473 (comment) |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Maybe) Resolves #36473
Description
Creating a temporary name when we add a new color to the custom palette.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).