Simplify frontend script for button-only search #32387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Type] Enhancement
aristath
commented
Jun 2, 2021
| @@ -68,6 +68,12 @@ | |||
| min-width: 0 !important; | |||
| } | |||
|
|
|||
| .wp-block-search__input { | |||
| transition-property: all; | |||
There was a problem hiding this comment.
This needs to be all and not flex-basis because using flex-basis some versions of Safari don't properly apply the transition.
|
Size Change: -329 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
7 tasks
|
This all looks great, except for one thing -- the width does not pass through to the front end, it will always be 100% width. I think it will need to pass the width and widthUnit attributes through to the front end to apply inline in this case. |
|
I fixed it, just needed the inline style applied in button only mode. Will merge this back into the parent PR. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the frontend script for button-only search.
This is not a PR against
trunk, it is an addition to #31719How has this been tested?
Tested editor & frontend behavior
Types of changes
Most of the JS was there to make transitions work. Migrated some of that behavior to CSS.
Checklist:
*.native.jsfiles for terms that need renaming or removal).