Simplify html selector in nav burger menu. #32303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Code Quality
7 tasks
|
Size Change: -1 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
talldan
approved these changes
May 28, 2021
|
There are some followups on submenu improvements, but I'd like to land #31878 first as that on its own changes the specificity of some of the margin rules. In this case, the overlay menu is so new I suspect many themes haven't had a chance to touch it. Part of it, as is the case so many times, is trying to find the delicate balance between having low specificity so themes can easily do what they please, and high specificity in order to make new features behave as envisioned. I'll definitely keep on this, though! Thank you for the fast review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #32269 (comment), this is a tiny PR that just improves the JS of the navigation block frontend burger menu.
How has this been tested?
Insert enough content on your page to scroll. Insert a navigation block, enable responsive, then publish and scale the window down below 600px so the menu appears. Open the menu and scroll — the content underneath should not scroll.
Same behavior as current trunk, in other words, just a code improvement.
Checklist:
*.native.jsfiles for terms that need renaming or removal).