Global Styles: Make the dependency of the star matcher explicit when translating theme.json
#30604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Code Quality
gziolo
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Nice improvement, thank you for making it more useful than before 😄
The next step would be to make it a general-purpose utility and refactor register_block_type_from_metadata in WordPress core ✨
You still need to fix coding style violations to move forward with this refactoring: https://github.com/WordPress/gutenberg/pull/30604/checks?check_run_id=2295013361
gziolo
changed the title
theme.json
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
oandregal
force-pushed
the
update/make-star-dependency-explicit
branch
from
5a17c4f to
33bbf6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #30541 so it can land in pieces and make reviews easier/quicker.
This PR improves the logic that processes the paths to translate. Instead of looking for
settingsit looks for the*element, which indicates that we should iterate over elements in that path. By making that dependency explicit, changes like those we plan at #30541 don't require any modifications in this code.How to test
npm run test-unit-php /var/www/html/wp-content/plugins/gutenberg/phpunit/class-wp-theme-json-resolver-test.php