-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default link to image_default_link_type for gallery #25582
Conversation
Size Change: +211 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
4b46a54
to
1034c45
Compare
1034c45
to
4a04b7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Alex, nice working with you on these! 👍
Is this feature integrated in Wordpress 5.5.3? |
@nicolasbrouard This won't be in WordPress 5.5.3, but it will be in the upcoming WordPress 5.6 due on 8th December (https://make.wordpress.org/core/5-6/). |
Awesome. Thanks a lot for the reply. |
Please review: As of WP 5.9 the |
Description
Fixes #10173 for galleries
Related to #25578 which fixes it for images
linkTo
valueimage_default_link_type
option fromoptions.php
to set default link for gallerieslinkTo
attribute to matchlink
values in PHP:'media'
→'file'
and'attachment'
→'post'
'post'
link
transformation (before'post'
wasn't getting transformed to'attachment'
intransforms.js
, but now with the block using the same values as the shortcode it doesn't need to be transformed)deprecated.js
with the attribute changetransforms.js
with the attribute changeHow has this been tested?
New gallery block
image_default_link_type
setting inoptions.php
to'post'
,'file'
, or'none'
Link to
option is correct: Attachment page for'post'
, Media file for'file'
or None for'none'
Migrate gallery block
Transform from shortcode
Screenshots
Types of changes
New feature? Bug fix?
Checklist: