-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code block: allow HTML editing & rich text #24689
Conversation
Size Change: -64 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
Failing unit test looks legit. I don't think you need to use |
Just needed to update the integration test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently block styles are still applied when editing as HTML, haha:
But that's not really the fault of this PR, so I wouldn't consider it a blocker. Everything else seems to be working perfectly. I quickly tested to make sure the block didn't get confused between actual HTML tags and "fake" ones created in visual mode. Thanks for working on this. 😄
fe684e4
to
d194272
Compare
Description
Fixes #6672.
How has this been tested?
Screenshots
Types of changes
Checklist: