Add block variations' keywords search support #24040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
mkaz and
youknowriad
as code owners
ntsekouras
force-pushed
the
add/variations-keywords-search-support
branch
from
1ab4b27 to
f47c28d
Compare
ntsekouras
added
the
[Feature] Block Variations
|
Size Change: +38 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
ntsekouras
changed the title
youknowriad
approved these changes
Jul 20, 2020
| accumulator.add( title ); | ||
| keywords.forEach( ( keyword ) => | ||
| accumulator.add( keyword ) | ||
| ); |
There was a problem hiding this comment.
Do you think the code here will be simpler if use arrays instead of Set?
return [ ...accumulator, title, ...keywords ] (and not more Arrary.from)
There was a problem hiding this comment.
Yes it would but variations can have same keywords and will be added to the array duplicates. This became to me really obvious with embed sharing many common keywords.
|
Nice one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds search support for
Block variations'keywords. Lays some groundwork for the refactoring ofEmbedblock to have all other embeds asBlock variations.Related to #22660.
How has this been tested?
To easily test it manually you can edit an existent not
isDefaultvariation by adding somekeywordsand test the inserter by searching your terms. Be aware to allow the variation to be searchable for your manual testing. For example incolumnsall variations have scope'block, that means you have to either comment it or addinserterinscopearray.Columns' variations in master.
Checklist: