[Mobile] Accessibility mark III #14886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, VoiceOver wouldn't scroll down the block list. The breaking change was located at the removal of this css property `font-family: $default-regular-font;` on the nextpage block. Addinb back that property to be able to scroll the blocks list again using VoiceOver.
etoledom
added
the
Mobile App - i.e. Android or iOS
|
This PR was replaced by many PRs in HackWeek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves support for Screen readers on the following blocks:
Note:
There was a problem after the last merge from master, where the example content wasn't scrolling with VoiceOver ON. This started happening after the merge of this PR: #14826. In particular because of the deletion of
font-family: $default-regular-font;, so I rolled back that change.Note 2:
A similar problem happens when there are just paragraph blocks. The block list becomes un-scrollable by VoiceOver. This issue seems to have been there for sometime now, so I decided to