Skip to content

Commit

Permalink
Clean up tsconfigs
Browse files Browse the repository at this point in the history
- Use specific types
- Remove redundant strict declarations
  • Loading branch information
sirreal committed Apr 28, 2020
1 parent 4c24595 commit 62ca114
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion packages/priority-queue/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"rootDir": "src",
"declarationDir": "build-types"
"declarationDir": "build-types",
"types": [ "requestidlecallback" ]
},
"include": [ "src/**/*" ]
}
1 change: 1 addition & 0 deletions packages/project-management-automation/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"compilerOptions": {
"rootDir": "lib",
"declarationDir": "build-types",
"types": [ "node" ],

// This is required due to a type error coming from missing types in @actions/github
"noImplicitAny": false
Expand Down
3 changes: 2 additions & 1 deletion packages/warning/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"rootDir": "src",
"declarationDir": "build-types"
"declarationDir": "build-types",
"types": [ "webpack-env" ]
},
"include": [ "src/**/*" ]
}
4 changes: 1 addition & 3 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

/* Strict Type-Checking Options */
"strict": true,
"strictNullChecks": true,
"noImplicitAny": true,

/* Additional Checks */
"noUnusedLocals": true,
Expand All @@ -31,7 +29,7 @@
"esModuleInterop": false,
"resolveJsonModule": true,

"typeRoots": [ "./node_modules/@types" ]
"types": []
},
"exclude": [
"**/benchmark",
Expand Down

0 comments on commit 62ca114

Please sign in to comment.