fix: unreported crash on 3d-visualizer #2062
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recently added data checks allowed invalid sized vertex arrays to be used as if they were valid making ImHex crash. Moved all the error messages into localization strings for translation.
|
Thank you! I usually use libfmt format strings for translatable strings that contain variables. That allows translators to insert those variables exactly where they want them and aren't limited to the order things are written in english. That will also reduce the number of entries you need in the language file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added data checks allowed invalid sized vertex arrays to be used as if they were valid making ImHex crash.
Moved all the error messages into localization strings for translation.