Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minReadySeconds option to statefulset #1913

Conversation

daniel-lee-sb
Copy link

Add minReadySeconds to storage Statefulset to allow users to set the minimum ready time before continuing rollout.

@github-actions github-actions bot added cluster vmcluster helm chart related issue metrics labels Jan 9, 2025
@Haleygo
Copy link
Contributor

Haleygo commented Jan 9, 2025

Thanks for the pull request, but I already added it in cd409e7.

@daniel-lee-sb
Copy link
Author

Thanks for the pull request, but I already added it in cd409e7.

Oh, thanks :) When can we use that!! 👍

@Haleygo
Copy link
Contributor

Haleygo commented Jan 9, 2025

Thanks for the pull request, but I already added it in cd409e7.

Oh, thanks :) When can we use that!! 👍

To be optimistic, I'd say this week)

@f41gh7
Copy link
Collaborator

f41gh7 commented Jan 9, 2025

Please note minReadySeconds is immutable field for StatefulSet Spec. Changing value for it will require manual action - kubectl delete statefulset NAME --cascade=orphan.

@Haleygo
Copy link
Contributor

Haleygo commented Jan 9, 2025

Please note minReadySeconds is immutable field for StatefulSet Spec. Changing value for it will require manual action - kubectl delete statefulset NAME --cascade=orphan.

@f41gh7 minReadySeconds is not an immutable field, can't find any doc:(, but you can try it

* spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordinals', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden

@f41gh7
Copy link
Collaborator

f41gh7 commented Jan 9, 2025

@f41gh7 minReadySeconds is not an immutable field, can't find any doc:(, but you can try it

Indeed, my bad, I thought it's immutable.

@Haleygo
Copy link
Contributor

Haleygo commented Jan 9, 2025

@daniel-lee-sb jfyi, victoria-metrics-cluster-0.17.0 has been released with above enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster vmcluster helm chart related issue metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants