-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of MultiPointType #443
Conversation
So we now have the parameter as de facto optional and we say that it is important and "should" be set - I think that is OK. But why not more consequently change the cardinality to 0:1 in order to clearly mark it as optional in the documentation table? That would require a slightly greater change in the documentation but it could not lead to confusion any more. (Do we have other places where an element of an optional part is mandatory?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be quite late to the party regarding the state of OJP 2.0, but the definitions in MultiPointType
are not really clear to me. Renaming or removing somePoints
is probably out of question, but we definitely should clarify the documentation. I hope this is still possible?
Co-authored-by: trurlurl <[email protected]>
Co-authored-by: trurlurl <[email protected]>
9bb9b1b
to
a135d31
Compare
Please resolve the conflicts so we can get this in. |
incorporated André's comment
@sgrossberndt as soon as André is happy, we can merge this one and then also the release |
@ue71603 What about the added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only blocked regarding to minOccurs="0", otherwise I am fine with the change.
@sgrossberndt when ok for you, then we can merge. |
I also just found out it had |
Apparently it was done on purpose back then by @ue71603: |
addresses: #442