-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving HikingProfile and CyclingProfile out of TripContentFilter #427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed PR removes both Profiles from TripRefineRequest and TripChangeRequest.
Should I add them there as well?
TripChangeRequestStructure - TripChangeParam - TripParams = TripParamStructure - TripMobilityFilter contains the profiles. TripRefineRequest does not. I have a more fundamental question: We only have TripResult of the trip to be refined, this does not seem to include the initial TripParams - how is that sufficient to re-retrieve the trip? |
Moving HikingProfile and CyclingProfile out of TripContentFilterGroup
310f769
to
42f89ec
Compare
Proposal if it is not sufficient: add new |
Moving HikingProfile and CyclingProfile out of TripContentFilterGroup
…e/OJP into hiking_and_cycling_profiles
@herlitze pls check for the filtergroup I added to trip refinement. I hope this is ok for you as well. |
@skinkie if ok, then pls approve and merge. |
The proposal is to move HikingProfile and CyclingProfile out of TripContentFilterGroup since they affect the search behavior and not the information to be returned about the trips found (filtering the information would be my interpretation of what TripContentFilter should do).