-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Transmodel TRIP REQUEST.Flexibilitywindow #372
Conversation
What is the use case for this field? When should it be filled and what are its implications / what are the expectations from the enquirers? |
Norman: Usually departure time is a hard use case. Expected result is the problem: How important is the adherence to the defined time. siri:StopPointRef<...> siri:StopPointRef<...> ==> Norman will discuss it. |
2ca0b77
to
2b8a701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added new TRIP REQUEST.FlexibilityWindow with an example and also new matching error definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
PlaceContext is also used in StopEventRequest which already contains the element TimeWindow. Isn't that too redundant / confusing?
-
As for the logic how to integrate DepArrTimeRange and NumberOfResults* - I suppose that they are treated to indicate what the results should cover at least (i.e., each one is able to extend the number of results).
db9f930
to
dac5d56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two improvements:
- Improve wording and fix typo in documentation
- Renamed problem code to TRIP_TIMEWINDOWTOOLARGE (should not contain "ERROR", will add a pull request for
TRIP_DATETIMEERROR
shortly) and since the problem is about the time window let's use that in the name of the problem as well.
Co-authored-by: trurlurl <[email protected]>
7d1434c
to
97e8127
Compare
No description provided.