Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Transmodel TRIP REQUEST.Flexibilitywindow #372

Merged
merged 17 commits into from
Jun 29, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Jun 14, 2023

No description provided.

@ue71603 ue71603 added enhancement New feature or request documentation labels Jun 14, 2023
@ue71603 ue71603 added this to the v2.0 milestone Jun 14, 2023
@normanoffel
Copy link

What is the use case for this field? When should it be filled and what are its implications / what are the expectations from the enquirers?

@ue71603
Copy link
Contributor Author

ue71603 commented Jun 19, 2023

Norman: Usually departure time is a hard use case. Expected result is the problem: How important is the adherence to the defined time.
Malte: We only have DepartureArrivalTime and TimeAllowance
Matthias: NumberOfResultsBefore ...
Prefered interval (choice): "DepartureArrivalTimeRange"

siri:StopPointRef<...>
20:123Z

siri:StopPointRef<...>

...
..

Norman: What this would mean. Within this time range I give you every trip and ignore the NumberOfResult?
Tim: In airline planers one sees even date changes (+/-3 days)
Malte: We would also calculate everything. Advise needed on the usage.
Matthias: ERROR Code

==> Norman will discuss it.

@ue71603 ue71603 force-pushed the FlexibilityWindow branch from 2ca0b77 to 2b8a701 Compare June 19, 2023 21:30
Aurige
Aurige previously approved these changes Jun 20, 2023
herlitze
herlitze previously approved these changes Jun 20, 2023
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 dismissed stale reviews from herlitze and Aurige via a913943 June 20, 2023 14:01
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
skinkie
skinkie previously approved these changes Jun 20, 2023
skinkie
skinkie previously approved these changes Jun 21, 2023
AndreasAtSBB
AndreasAtSBB previously approved these changes Jun 21, 2023
Copy link

@AndreasAtSBB AndreasAtSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added new TRIP REQUEST.FlexibilityWindow with an example and also new matching error definitions.

Copy link
Contributor

@trurlurl trurlurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. PlaceContext is also used in StopEventRequest which already contains the element TimeWindow. Isn't that too redundant / confusing?

  2. As for the logic how to integrate DepArrTimeRange and NumberOfResults* - I suppose that they are treated to indicate what the results should cover at least (i.e., each one is able to extend the number of results).

OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 dismissed stale reviews from AndreasAtSBB and skinkie via 0bcd56c June 21, 2023 22:41
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 force-pushed the FlexibilityWindow branch from db9f930 to dac5d56 Compare June 21, 2023 22:44
skinkie
skinkie previously approved these changes Jun 21, 2023
@ue71603
Copy link
Contributor Author

ue71603 commented Jun 23, 2023

Wit the comment from André concerning the TimeWindow in StopEventRequest, I guess it is better to remodel the FlexibilityWindow here.
image

skinkie
skinkie previously approved these changes Jun 23, 2023
trurlurl
trurlurl previously approved these changes Jun 23, 2023
Copy link
Contributor

@sgrossberndt sgrossberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it

@sgrossberndt sgrossberndt dismissed stale reviews from trurlurl and skinkie via ba5dff8 June 23, 2023 14:02
Copy link
Contributor

@sgrossberndt sgrossberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two improvements:

@ue71603 ue71603 force-pushed the FlexibilityWindow branch from 7d1434c to 97e8127 Compare June 29, 2023 15:12
@skinkie skinkie merged commit a061705 into changes_for_v1.1 Jun 29, 2023
@skinkie skinkie deleted the FlexibilityWindow branch June 29, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc updated enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants