Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adaption of IdTypes #348

Merged
merged 6 commits into from
Apr 11, 2023
Merged

adaption of IdTypes #348

merged 6 commits into from
Apr 11, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Apr 4, 2023

Each Id has now its own type

@ue71603 ue71603 added enhancement New feature or request documentation labels Apr 4, 2023
@ue71603 ue71603 added this to the v2.0 milestone Apr 4, 2023
@ue71603 ue71603 mentioned this pull request Apr 4, 2023
Closed
trurlurl
trurlurl requested changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@trurlurl trurlurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that at least the following id's would also have to be updated: FromLegIdRef, ToLegIdRef (OJP_FareSupport.xsd and OJP_Fare.xsd), TripId (in TripSummarStructure), FromTripIdRef and ToTripIdRef (OJP_Fare.xsd). But I somehow don't understand the logic or intent of the ...IdRef... names.

@ue71603
Copy link
Contributor Author

ue71603 commented Apr 7, 2023

I think that at least the following id's would also have to be updated: FromLegIdRef, ToLegIdRef (OJP_FareSupport.xsd and OJP_Fare.xsd), TripId (in TripSummarStructure), FromTripIdRef and ToTripIdRef (OJP_Fare.xsd). But I somehow don't understand the logic or intent of the ...IdRef... names.

Many ref point to a reference structure. But here, when it is just within the Trip I reference directly the ObjectIdType. I adapted it just as you suggested and fixed one that I missed before.

@ue71603 ue71603 requested a review from trurlurl April 7, 2023 10:39
Aurige
Aurige reviewed Apr 7, 2023
View reviewed changes
OJP/OJP_Fare.xsd Outdated
@@ -208,22 +214,22 @@
</xs:annotation>
<xs:sequence>
<xs:element ref="FareProductRef"/>
<xs:element name="FromTripIdRef" type="ObjectIdType">
<xs:element name="FromTripIdRef" type="LegObjectIdType">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be TripObjectIdType ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and now it is. tnx

ue71603
ue71603 commented Apr 7, 2023
View reviewed changes
OJP/OJP_Fare.xsd Outdated Show resolved Hide resolved
@skinkie skinkie merged commit a77556f into changes_for_v1.1 Apr 11, 2023
@skinkie skinkie deleted the new_id_types branch April 11, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trurlurl trurlurl trurlurl approved these changes

@Aurige Aurige Aurige approved these changes

@skinkie skinkie skinkie approved these changes

@sgrossberndt sgrossberndt Awaiting requested review from sgrossberndt

Assignees
No one assigned
Labels
doc updated enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ue71603 @skinkie @Aurige @trurlurl