Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing annotations #332

Merged
merged 6 commits into from
Mar 9, 2023
Merged

Missing annotations #332

merged 6 commits into from
Mar 9, 2023

Conversation

trurlurl
Copy link
Contributor

@trurlurl trurlurl commented Mar 8, 2023

I added annotations to complete the documentation tables.

skinkie
skinkie previously approved these changes Mar 8, 2023
Copy link
Contributor

@sgrossberndt sgrossberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup and improvement, thanks!

OJP/OJP_Locations.xsd Outdated Show resolved Hide resolved
OJP/OJP_Locations.xsd Outdated Show resolved Hide resolved
ue71603
ue71603 previously approved these changes Mar 9, 2023
OJP/OJP_Locations.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 dismissed stale reviews from skinkie and themself via e7fd83a March 9, 2023 10:25
OJP/OJP_Locations.xsd Outdated Show resolved Hide resolved
ue71603
ue71603 previously approved these changes Mar 9, 2023
sgrossberndt
sgrossberndt previously approved these changes Mar 9, 2023
@github-actions github-actions bot dismissed stale reviews from sgrossberndt and ue71603 via 857e6af March 9, 2023 10:26
@sgrossberndt sgrossberndt requested review from ue71603 and skinkie March 9, 2023 10:27
@sgrossberndt
Copy link
Contributor

@skinkie Please approve again and squash-and-merge :-)

@skinkie skinkie merged commit e378001 into changes_for_v1.1 Mar 9, 2023
@sgrossberndt
Copy link
Contributor

Please delete the branch after merging.

@sgrossberndt sgrossberndt deleted the missing_annotations branch March 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants