Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added annotation for GeoPosition #327

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Added annotation for GeoPosition #327

merged 4 commits into from
Mar 13, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Mar 3, 2023

No description provided.

@ue71603 ue71603 added this to the v2.0 milestone Mar 3, 2023
trurlurl
trurlurl previously approved these changes Mar 7, 2023
View reviewed changes
skinkie
skinkie reviewed Mar 8, 2023
View reviewed changes
OJP/OJP_PlaceSupport.xsd Outdated Show resolved Hide resolved
skinkie
skinkie previously approved these changes Mar 8, 2023
View reviewed changes
@sgrossberndt sgrossberndt changed the title GeoPosition needs an Annotation too Added annotation for GeoPosition Mar 9, 2023
sgrossberndt
sgrossberndt previously approved these changes Mar 9, 2023
View reviewed changes
skinkie
skinkie previously approved these changes Mar 9, 2023
View reviewed changes
@skinkie
Copy link
Contributor

skinkie commented Mar 9, 2023

@sgrossberndt was there now an option to do this without merging again?

@sgrossberndt
Copy link
Contributor

not yet

@ue71603 ue71603 dismissed stale reviews from skinkie and sgrossberndt via 3176db7 March 9, 2023 14:04
@ue71603 ue71603 force-pushed the GeoPosition_with_Annotation branch from 21fe5ae to 3176db7 Compare March 9, 2023 14:04
trurlurl
trurlurl reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@trurlurl trurlurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we have the OJP GeoPositionStructure for? If GeoPositionStructure were redundant with siri:LocationStructure, I would find it nice to always use the same of the two.

@ue71603
Copy link
Contributor Author

ue71603 commented Mar 10, 2023

@trurlurl Where did you find that structure? In my view it does not exist.

@trurlurl
Copy link
Contributor

@trurlurl Where did you find that structure? In my view it does not exist.

@ue71603 Your're right - it doesn't exist any more (used to be in OJP_Utility.xsd). So my comment is irrelevant / resolved.

@skinkie skinkie merged commit d96a91a into changes_for_v1.1 Mar 13, 2023
@skinkie skinkie deleted the GeoPosition_with_Annotation branch March 14, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trurlurl trurlurl trurlurl approved these changes

@sgrossberndt sgrossberndt sgrossberndt approved these changes

@skinkie skinkie skinkie approved these changes

@AndreasAtSBB AndreasAtSBB Awaiting requested review from AndreasAtSBB

Assignees
No one assigned
Labels
doc updated
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ue71603 @skinkie @sgrossberndt @trurlurl